fix(protocol): allow srcOwner to have unlimited gas limit on dest retry invocation
#17705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaki2004
requested review from
Brechtpd,
dantaik,
KorbinianK,
swarna1101 and
cyberhorsey
and removed request for
Brechtpd
fix(protocol): allow
|
| Severity Level | Results | |
|---|---|---|
| Contracts | Critical High Medium Low Note Total |
2 2 0 8 42 54 |
| Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
|
@adaki2004 What do you think we simply use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beside
destOwner, also allowsrcOwnerto callretryMessagewith non restrictive gas limit. (This is due to the fact of discord messages in question.)The only downside of this is a very rare possibility of: someone on the destination chain, control the
srcOwneraddress and make the message failed -> but even in this case, highly unlikely that anyone would set up a sniper bot for this action since it would result in 0 capital gains, as the funds were be available to re-claim it on the source chain, by the originalsrcOwner, who is indeed in charge on the source chain.Given the fact we ran into an edge case with contracts being the destination owners, but lacking the relay function to
retryMessagewith unlimited gas, mght be worth considering this additionOR
If the option is to let them upgrade their contracts (as per discord message link suggestions above), than it's OK to close and not merge this PR.